From 38276296f21200bf7faf66012da24c52e7f053d2 Mon Sep 17 00:00:00 2001 From: Jan Beulich Date: Fri, 22 May 2015 10:13:30 +0200 Subject: [PATCH] x86/shadow: fix uninitialized rc in shadow_track_dirty_vram() Commit bd1b4a71b3 ("x86/shadow: fix shadow_track_dirty_vram to work on hvm guests"), trying to mirror its HAP counterpart, deleted a couple of assignments to rc without making sure rc is initialized on all paths. Coverity ID: 1299410 Signed-off-by: Jan Beulich Reviewed-by: Andrew Cooper Acked-by: Tim Deegan --- xen/arch/x86/mm/shadow/common.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/xen/arch/x86/mm/shadow/common.c b/xen/arch/x86/mm/shadow/common.c index 9e9d19f20e..654bacc72f 100644 --- a/xen/arch/x86/mm/shadow/common.c +++ b/xen/arch/x86/mm/shadow/common.c @@ -3518,7 +3518,7 @@ int shadow_track_dirty_vram(struct domain *d, unsigned long nr, XEN_GUEST_HANDLE_64(uint8) guest_dirty_bitmap) { - int rc; + int rc = 0; unsigned long end_pfn = begin_pfn + nr; unsigned long dirty_size = (nr + 7) / 8; int flush_tlb = 0; @@ -3550,10 +3550,7 @@ int shadow_track_dirty_vram(struct domain *d, } if ( !nr ) - { - rc = 0; goto out; - } dirty_bitmap = vzalloc(dirty_size); if ( dirty_bitmap == NULL ) -- 2.30.2